-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Frame support #204
add Frame support #204
Conversation
@goosewobbler is attempting to deploy a commit to the LFE Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @goosewobbler, is this teal colour on the logo following brand guidelines for Frame? I haven't seen their logo used in this manner before. |
Yes, we're trying a logo that will work both on dark and light themes. This logo variant is currently used as the "connected" state of the companion extension. |
@lochie Is there anything left to do here? How might I replace the provider? We have an extensionless method of connection via https://github.com/goosewobbler/web3-onboard/blob/frame-connector/packages/frame/src/index.ts#L20 We also have a new WAGMI connector on the way which will support both connection mechanisms: |
@goosewobbler you could always use the theme variables to define the icon colour within the svg e.g |
@goosewobbler sorry for the delay on this, this lgtm for the injected provider being detected, we're happy to merge this in. regarding with regards to the wagmi connector, if that gets merged into wagmi we will actively set up support for it within our default setup as we want to keep 1:1 parity with whatever wagmi supports. sorry again for the delay, and thanks for the contribution! 😊 |
Adding injected support for Frame.